Skip to content

chore: optimize getHostInfoByStrategy in PluginManager #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

chore: optimize getHostInfoByStrategy in PluginManager #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 51 additions & 13 deletions common/lib/plugin_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class PluginChain<T> {

export class PluginManager {
private static readonly PLUGIN_CHAIN_CACHE = new Map<[string, HostInfo], PluginChain<any>>();
private static readonly STRATEGY_PLUGIN_CHAIN_CACHE = new Map<ConnectionPlugin[], Set<ConnectionPlugin>>();
private static readonly ALL_METHODS: string = "*";
private static readonly CONNECT_METHOD = "connect";
private static readonly FORCE_CONNECT_METHOD = "forceConnect";
Expand Down Expand Up @@ -272,28 +273,65 @@ export class PluginManager {
}

acceptsStrategy(role: HostRole, strategy: string) {
for (const plugin of this._plugins) {
const pluginSubscribedMethods = plugin.getSubscribedMethods();
const isSubscribed =
pluginSubscribedMethods.has(PluginManager.ALL_METHODS) || pluginSubscribedMethods.has(PluginManager.ACCEPTS_STRATEGY_METHOD);
let chain: Set<ConnectionPlugin> = PluginManager.STRATEGY_PLUGIN_CHAIN_CACHE.get(this._plugins);
if (!chain) {
chain = new Set();
let acceptsStrategy: boolean = false;

for (const plugin of this._plugins) {
if (
plugin.getSubscribedMethods().has(PluginManager.ALL_METHODS) ||
plugin.getSubscribedMethods().has(PluginManager.ACCEPTS_STRATEGY_METHOD)
) {
chain.add(plugin);
if (!acceptsStrategy && plugin.acceptsStrategy(role, strategy)) {
acceptsStrategy = true;
}
}
}

if (isSubscribed && plugin.acceptsStrategy(role, strategy)) {
return true;
PluginManager.STRATEGY_PLUGIN_CHAIN_CACHE.set(this._plugins, chain);
return acceptsStrategy;
} else {
for (const plugin of chain) {
if (plugin.acceptsStrategy(role, strategy)) {
return true;
}
}
}

return false;
}

getHostInfoByStrategy(role: HostRole, strategy: string, hosts?: HostInfo[]): HostInfo {
for (const plugin of this._plugins) {
const pluginSubscribedMethods = plugin.getSubscribedMethods();
const isSubscribed =
pluginSubscribedMethods.has(PluginManager.ALL_METHODS) || pluginSubscribedMethods.has(PluginManager.GET_HOST_INFO_BY_STRATEGY_METHOD);

if (isSubscribed) {
let chain: Set<ConnectionPlugin> = PluginManager.STRATEGY_PLUGIN_CHAIN_CACHE.get(this._plugins);
if (!chain) {
chain = new Set();
let host: HostInfo;

for (const plugin of this._plugins) {
if (
plugin.getSubscribedMethods().has(PluginManager.ALL_METHODS) ||
plugin.getSubscribedMethods().has(PluginManager.GET_HOST_INFO_BY_STRATEGY_METHOD)
) {
chain.add(plugin);
if (!host) {
try {
host = plugin.getHostInfoByStrategy(role, strategy, hosts);
} catch (error) {
// This plugin does not support the provided strategy, ignore the exception and move on
}
}
}
}
PluginManager.STRATEGY_PLUGIN_CHAIN_CACHE.set(this._plugins, chain);
if (host) {
return host;
}
} else {
for (const plugin of chain) {
try {
const host = plugin.getHostInfoByStrategy(role, strategy, hosts);
const host: HostInfo = plugin.getHostInfoByStrategy(role, strategy, hosts);
if (host) {
return host;
}
Expand Down
Loading