chore: refactor static setConnectionProvider method #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
requested review from
leszek-bq and
leszekamz
and removed request for
leszekamz
sophia-bq
force-pushed
the
chore/refactor-set-connection-provider
branch
from
14b3196 to
5c4646e
Compare
sophia-bq
added
ready for review
sergiyvamz
reviewed
Nov 21, 2024
sergiyvamz
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor setting a non-default ConnectionProvider to be done through a connection property instead of a static method.
Description
Adds a new connection property
connectionProviderthat allows users to pass a non-default provider through a connection property.This replaces the existing static
setConnectionProvidermethod that gives any code access to modify the connection provider manager on the go.The value of
ConnectionProviderManager.connProviderwhich is updated by the connection property remains static.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.