Handle propagator rename breaking change in OTel JS 0.26.0 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
changed the title
NathanielRN
added a commit
to NathanielRN/aws-otel-lambda
that referenced
this pull request
Jan 27, 2022
…#167) * Update Lambda Layer with OTel Python 1.6.2 and 0.25b2 * Just remove the OTEL_TRACES_EXPORTER because its a default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to #160.
The OTel JS upgrading guide had said that the
HttpTraceContextPropagatorwas renamed in0.25.0so since we were upgrading from0.25.0to0.26.0there should have been no need to change anything. However, this breaking change (open-telemetry/opentelemetry-js#2429) was actually introduced in0.26.0as seen by the OTel JS release notes. Therefore, we need to account for that in this0.26.0release.Link to tracking Issue:
N/A
Testing:
This time, I confirmed there were no error outputs when I did
cd nodejs/ && ./build.sheven after scrolling to the top.Documentation:
N/A