netkvm: add netkvm_poll_mode test case #4353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test result: |
heywji
force-pushed
the
add_pollmode_case2
branch
from
3a430f1 to
653d703
Compare
Poll mode is a must-have feature for Windows Server 2025 and Windows 11. Signed-off-by: Wenkang Ji <[email protected]>
heywji
force-pushed
the
add_pollmode_case2
branch
from
653d703 to
9b32bdb
Compare
|
@leidwang Hi Leidong, please help review this poll mode patch. I have completed it now. |
leidwang
reviewed
Sep 22, 2025
|
|
||
| :param test: QEMU test object | ||
| :param params: Dictionary with the test parameters | ||
| :param env: Dictionary with test environmen. |
There was a problem hiding this comment.
Suggested change
| :param env: Dictionary with test environmen. | |
| :param env: Dictionary with test environment. |
| mapping_output = re.findall(keyword, result) | ||
| if not mapping_output: | ||
| test.error("Can't get %s from traceview", keyword) | ||
| return mapping_output |
There was a problem hiding this comment.
No need to return any value for run()
Comment on lines
+14
to
+15
| setup_rss_queues = '"*NumRssQueues" %s' | ||
| check_rss_queues = "*NumRssQueues" |
There was a problem hiding this comment.
rss_queue_name = "*NumRssQueues"
Please update these lines as we discussed.
| queues = ${smp} | ||
| variants: | ||
| - rss_16: | ||
| rss_queues = 16 |
leidwang
reviewed
Sep 22, 2025
| restore_image_after_testing = yes | ||
| # this case only tested on prewhql255 or higher version | ||
| cdroms += " virtio" | ||
| required_virtio_win_prewhql = [0.1.255, ) |
There was a problem hiding this comment.
I think we also need add virtio-win version here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poll mode is a must-have feature for Windows Server 2025 and Windows 11.
ID: 2267
Signed-off-by: Wenkang Ji [email protected]