Skip to content

device_option_check:fix sq_inq paremeter error #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

device_option_check:fix sq_inq paremeter error #4325

merged 1 commit into from
Sep 18, 2025

Conversation

qingwangrh
Copy link
Contributor

The --page 0x83 is not expected in latest Linux.

Using --page di or -i directly to get the
device identification.

ID:3925

@qingwangrh
device_option_check:fix sq_inq parameter error
b0ef7b1 
The --page 0x83 is not expected in the
latest Linux.
Using --page di or -i directly to get the
device identification.

Signed-off-by: qingwangrh <[email protected]>
@qingwangrh qingwangrh force-pushed the 3925_fix_page_blockid branch from adb2fb2 to b0ef7b1 Compare June 27, 2025 10:05
@qingwangrh
Copy link
Contributor Author

python ConfigTest.py --testcase=device_option_check --iothread_scheme=roundrobin --nr_iothreads=2 --platform=x86_64 --guestname=RHEL.9.4,RHEL.10.1 --driveformat=virtio_scsi,virtio_blk --imageformat=qcow2 --machines=q35 --customsparams="vm_mem_limit = 12G\nimage_aio=io_uring" --firmware=default_bios --netdst=virbr0 --clone=no

(01/12) Host_RHEL.m10.u1.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: STARTED
(01/12) Host_RHEL.m10.u1.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: PASS (32.33 s)
(02/12) Host_RHEL.m10.u1.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: STARTED
(02/12) Host_RHEL.m10.u1.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: PASS (37.65 s)
(03/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.default_drive_format.q35: STARTED
(03/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.default_drive_format.q35: PASS (30.36 s)
(04/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.special_drive_format.q35: STARTED
(04/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.special_drive_format.q35: PASS (34.57 s)
(05/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.default_drive_format.q35: STARTED
(05/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.default_drive_format.q35: PASS (32.85 s)
(06/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.special_drive_format.q35: STARTED
(06/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.special_drive_format.q35: PASS (33.72 s)
(07/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: STARTED
(07/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.1.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: PASS (91.95 s)
(08/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.default_drive_format.q35: STARTED
(08/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.default_drive_format.q35: PASS (29.93 s)
(09/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.special_drive_format.q35: STARTED
(09/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_disk.special_drive_format.q35: PASS (29.95 s)
(10/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.default_drive_format.q35: STARTED
(10/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.default_drive_format.q35: PASS (30.35 s)
(11/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.special_drive_format.q35: STARTED
(11/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_wwn_check.wwn_cdrom.special_drive_format.q35: PASS (29.82 s)
(12/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: STARTED
(12/12) Host_RHEL.m10.u1.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.device_option_check.blk_serial_check.q35: PASS (29.68 s)
RESULTS : PASS 12 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@qingwangrh
Copy link
Contributor Author

@XueqiangWei @fbq815 Please help to review,thanks

XueqiangWei
XueqiangWei approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@XueqiangWei XueqiangWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Acked-by: [email protected]

@XueqiangWei
Copy link
Contributor

@fbq815 Could you please help review it? Many thanks.

@fbq815
Copy link
Contributor

fbq815 commented Sep 17, 2025

@qingwangrh for RHEL9 it LGTM, but for RHEL10 I think we need to modify the block checking command on s390x, details in jira task

fbq815
fbq815 approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after offline discussion and double check, the failure was caused by patch aplly issue, after re aplly and run, this could PASS as expected

@XueqiangWei XueqiangWei merged commit 9031872 into autotest:master Sep 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XueqiangWei XueqiangWei XueqiangWei approved these changes

+1 more reviewer

@fbq815 fbq815 fbq815 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingwangrh @XueqiangWei @fbq815