Skip to content

fix: use correct start scripts for federations #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2023
Merged

fix: use correct start scripts for federations #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
400ff0a
fix: use correct start scripts for federations
xoac Oct 13, 2023
b162f4e
fix: before killing pid check for existance. Continue for all pids
xoac Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions federation/dynamic-schema/start.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,24 @@
set -eumo pipefail

function cleanup {
kill "$PRODUCTS_ROVER_PID"
kill "$REVIEWS_ROVER_PID"
kill "$ACCOUNTS_PID"
kill "$PRODUCTS_PID"
kill "$REVIEWS_PID"
for pid in "${PRODUCTS_ROVER_PID:-}" "${REVIEWS_ROVER_PID:-}" "${ACCOUNTS_PID:-}" "${PRODUCTS_PID:-}" "${REVIEWS_PID:-}"; do
# try kill all registered pids
[ -n "$pid" ] && kill -0 "$pid" 2>/dev/null && kill "$pid" || echo "Could not kill $pid"
done
}
trap cleanup EXIT

cargo build --bin static-federation-accounts
cargo build --bin static-federation-products
cargo build --bin static-federation-reviews
cargo build --bin dynamic-federation-accounts
cargo build --bin dynamic-federation-products
cargo build --bin dynamic-federation-reviews

cargo run --bin static-federation-accounts &
cargo run --bin dynamic-federation-accounts &
ACCOUNTS_PID=$!

cargo run --bin static-federation-products &
cargo run --bin dynamic-federation-products &
PRODUCTS_PID=$!

cargo run --bin static-federation-reviews &
cargo run --bin dynamic-federation-reviews &
REVIEWS_PID=$!

sleep 3
Expand All @@ -33,4 +32,4 @@ PRODUCTS_ROVER_PID=$!
sleep 1
rover dev --url http://localhost:4003 --name reviews &
REVIEWS_ROVER_PID=$!
fg %4
fg %4
21 changes: 10 additions & 11 deletions federation/static-schema/start.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,24 @@
set -eumo pipefail

function cleanup {
kill "$PRODUCTS_ROVER_PID"
kill "$REVIEWS_ROVER_PID"
kill "$ACCOUNTS_PID"
kill "$PRODUCTS_PID"
kill "$REVIEWS_PID"
for pid in "${PRODUCTS_ROVER_PID:-}" "${REVIEWS_ROVER_PID:-}" "${ACCOUNTS_PID:-}" "${PRODUCTS_PID:-}" "${REVIEWS_PID:-}"; do
# try kill all registered pids
[ -n "$pid" ] && kill -0 "$pid" 2>/dev/null && kill "$pid" || echo "Could not kill $pid"
done
}
trap cleanup EXIT

cargo build --bin dynamic-federation-accounts
cargo build --bin dynamic-federation-products
cargo build --bin dynamic-federation-reviews
cargo build --bin static-federation-accounts
cargo build --bin static-federation-products
cargo build --bin static-federation-reviews

cargo run --bin dynamic-federation-accounts &
cargo run --bin static-federation-accounts &
ACCOUNTS_PID=$!

cargo run --bin dynamic-federation-products &
cargo run --bin static-federation-products &
PRODUCTS_PID=$!

cargo run --bin dynamic-federation-reviews &
cargo run --bin static-federation-reviews &
REVIEWS_PID=$!

sleep 3
Expand Down