[ty] Preserve qualifiers when accessing attributes on unions/intersections #20114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
changed the title
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
sharkdp
force-pushed
the
david/attribute-access-on-intersections-again
branch
from
f0c8f05 to
1760fd6
Compare
sharkdp
commented
Aug 27, 2025
| @@ -398,7 +398,7 @@ def f_okay(c: Callable[[], None]): | |||
| c.__qualname__ = "my_callable" | |||
|
|
|||
| result = getattr_static(c, "__qualname__") | |||
| reveal_type(result) # revealed: Never | |||
| reveal_type(result) # revealed: property | |||
There was a problem hiding this comment.
Slightly surprised that there was no TODO here. This looks fine?
sharkdp
commented
Aug 27, 2025
Comment on lines
+9741
to
+9742
| let mut all_unbound = true; | ||
| let mut any_definitely_bound = false; |
There was a problem hiding this comment.
The implementation here now follows map_with_boundness just above. It was wrong before (see test change in callable.md).
AlexWaygood
approved these changes
Aug 27, 2025
Comment on lines
+9753
to
9755
| if member_boundness == Boundness::Bound { | ||
| any_definitely_bound = true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if member_boundness == Boundness::Bound { | |
| any_definitely_bound = true; | |
| } | |
| any_definitely_bound |= member_boundness == Boundness::Bound; |
There was a problem hiding this comment.
I think I prefer what we have in terms of readability. Not sure if it compiles to worse code (probably not?), but this is not a hot code path anyway.
carljm
added a commit
to leandrobbraga/ruff
that referenced
this pull request
Aug 27, 2025
* main: [`ruff`] Preserve relative whitespace in multi-line expressions (`RUF033`) (astral-sh#19647) [ty] Optimize TDD atom ordering (astral-sh#20098) [`airflow`] Extend `AIR311` and `AIR312` rules (astral-sh#20082) [ty] Preserve qualifiers when accessing attributes on unions/intersections (astral-sh#20114) [ty] Fix the inferred interface of specialized generic protocols (astral-sh#19866) [ty] Infer slightly more precise types for comprehensions (astral-sh#20111) [ty] Add more tests for protocols (astral-sh#20095) [ty] don't eagerly unpack aliases in user-authored unions (astral-sh#20055) [`flake8-use-pathlib`] Update links to the table showing the correspondence between `os` and `pathlib` (astral-sh#20103) [`flake8-use-pathlib`] Make `PTH100` fix unsafe because it can change behavior (astral-sh#20100) [`flake8-use-pathlib`] Delete unused `Rule::OsSymlink` enabled check (astral-sh#20099) [ty] Add search paths info to unresolved import diagnostics (astral-sh#20040) [`flake8-logging-format`] Add auto-fix for f-string logging calls (`G004`) (astral-sh#19303) Add a `ScopeKind` for the `__class__` cell (astral-sh#20048) Fix incorrect D413 links in docstrings convention FAQ (astral-sh#20089) [ty] Refactor inlay hints structure to use separate parts (astral-sh#20052)
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…tions (astral-sh#20114) ## Summary Properly preserve type qualifiers when accessing attributes on unions and intersections. This is a prerequisite for astral-sh#19579. Also fix a completely wrong implementation of `map_with_boundness_and_qualifiers`. It now closely follows `map_with_boundness` (just above). ## Test Plan I thought about it, but didn't find any easy way to test this. This only affected `Type::member`. Things like validation of attribute writes (where type qualifiers like `ClassVar` and `Final` are important) were already handling things correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properly preserve type qualifiers when accessing attributes on unions and intersections. This is a prerequisite for #19579.
Also fix a completely wrong implementation of
map_with_boundness_and_qualifiers. It now closely followsmap_with_boundness(just above).Test Plan
I thought about it, but didn't find any easy way to test this. This only affected
Type::member. Things like validation of attribute writes (where type qualifiers likeClassVarandFinalare important) were already handling things correctly.