[ty] Fix namespace packages that behave like partial stubs #19994
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
| `/packages/foo-stubs/both.py`: | ||
| `/packages/foo-stubs/both.pyi`: | ||
|
|
||
| ```py | ||
| ```pyi |
There was a problem hiding this comment.
(All these changes are a driveby fix that doesn't change the results but I realized was wrong and should be fixed)
|
|
||
| ## Namespace stub with missing module | ||
|
|
||
| Namespace stubs are always partial. |
There was a problem hiding this comment.
Do you have a reference that backs this claim? This is somewhat surprising to me and I remember that I struggled to find good documentation for what's supposed to happen in some of those non obvious cases
There was a problem hiding this comment.
https://peps.python.org/pep-0561/#partial-stub-packages
Type checkers should treat namespace packages within stub-packages as incomplete since multiple distributions may populate them. Regular packages within namespace packages in stub-package distributions are considered complete unless a py.typed with partial\n is included.
There was a problem hiding this comment.
It would be great to add this link to the test
In implementing partial stubs I had observed that this continue in the namespace package code seemed erroneous since the same continue for partial stubs didn't work. Unfortunately I wasn't confident enough to push on that hunch. Fortunately I remembered that hunch to make this an easy fix.
The issue with the continue is that it bails out of the current search-path without testing any .py files. This breaks when for example
googleandgoogle-stubs/types-googleare both in the same site-packages dir -- failing to find a module intypes-googlehas us completely skip overgoogle!Fixes astral-sh/ty#520