[ty] Implement partial stubs #19931
[ty] Implement partial stubs #19931
Conversation
|
(I need to write some proper tests but this fixes |
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
| @@ -796,7 +809,7 @@ fn resolve_name_in_search_path( | |||
| context: &ResolverContext, | |||
| name: &RelaxedModuleName, | |||
| search_path: &SearchPath, | |||
| ) -> Result<(PackageKind, ResolvedName), PackageKind> { | |||
| ) -> Result<(PackageKind, PyTyped, ResolvedName), (PackageKind, PyTyped)> { | |||
There was a problem hiding this comment.
This is really gross and I considered factoring a proper type but literally only one function deals with this and immediately unpacks these so... eh?
| /// This implementation implies that once a `py.typed` is specified | ||
| /// all child packages inherit it, so they can never become Untyped. | ||
| /// However they can override whether that's Full or Partial by | ||
| /// redeclaring a `py.typed` file of their own. | ||
| fn inherit_parent(self, parent: Self) -> Self { |
There was a problem hiding this comment.
No idea if this is correct but i like it conceptually
There was a problem hiding this comment.
The spec isn't totally clear here, it just says "This marker applies recursively: if a top-level package includes it, all its sub-packages MUST support type checking as well." It doesn't say anything about a sub-package going to partial where its parent was "full", or whatever. But I think this behavior is sensible.
|
| /// This implementation implies that once a `py.typed` is specified | ||
| /// all child packages inherit it, so they can never become Untyped. | ||
| /// However they can override whether that's Full or Partial by | ||
| /// redeclaring a `py.typed` file of their own. | ||
| fn inherit_parent(self, parent: Self) -> Self { |
There was a problem hiding this comment.
The spec isn't totally clear here, it just says "This marker applies recursively: if a top-level package includes it, all its sub-packages MUST support type checking as well." It doesn't say anything about a sub-package going to partial where its parent was "full", or whatever. But I think this behavior is sensible.
|
Added tests |
There was a problem hiding this comment.
Nice. This looks good to me.
Can you coordinate with @BurntSushi to make sure partial is also considered for completions (#19883)?
It would be nice if some of those module resolver tests could be mdtests. I ported some module resolver tests but haven't had the time to migrate all, but it would be nice if we can avoid adding new once (unless it uses a mdtest feature that we aren't supporting yet)
| /// Testing stub packages can be missing modules and we don't fallthrough | ||
| /// to the impl (when they don't declare py.typed partial) | ||
| #[test] | ||
| fn resolve_stub_module_missing_non_partial() { |
There was a problem hiding this comment.
Could this be an mdtest similar to
I added astral-sh/ty#1042 to track this. |
|
Oh sure I can make these mdtests. |
Fixes astral-sh/ty#184