[ty] Avoid rechecking the entire project when changing the opened files #19463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
server
MichaReiser
requested review from
carljm,
AlexWaygood,
sharkdp and
dcreager
as code owners
MichaReiser
requested review from
ibraheemdev and
dhruvmanila
and removed request for
dcreager,
sharkdp,
AlexWaygood and
carljm
|
MichaReiser
force-pushed
the
micha/fix-reparse-open-change
branch
from
89f1ba6 to
be9b1f5
Compare
ibraheemdev
approved these changes
Jul 21, 2025
dcreager
added a commit
that referenced
this pull request
Jul 22, 2025
* main: (76 commits) Move fix suggestion to subdiagnostic (#19464) [ty] Implement non-stdlib stub mapping for classes and functions (#19471) [ty] Disallow illegal uses of `ClassVar` (#19483) [ty] Disallow `Final` in function parameter/return-type annotations (#19480) [ty] Extend `Final` test suite (#19476) [ty] Minor change to diagnostic message for invalid Literal uses (#19482) [ty] Detect illegal non-enum attribute accesses in Literal annotation (#19477) [ty] Reduce size of `TypeInference` (#19435) Run MD tests for Markdown-only changes (#19479) Revert "[ty] Detect illegal non-enum attribute accesses in Literal annotation" [ty] Detect illegal non-enum attribute accesses in Literal annotation [ty] Added semantic token support for more identifiers (#19473) [ty] Make tuple subclass constructors sound (#19469) [ty] Pass down specialization to generic dataclass bases (#19472) [ty] Garbage-collect reachability constraints (#19414) [ty] Implicit instance attributes declared `Final` (#19462) [ty] Expansion of enums into unions of literals (#19382) [ty] Avoid rechecking the entire project when changing the opened files (#19463) [ty] Add warning for unknown `TY_MEMORY_REPORT` value (#19465) [ty] Sync vendored typeshed stubs (#19461) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed when playing with the extension that ty always reparses all AST nodes
after I changed the open files in the editor.
The reason for this is that
check_file_impldepends ondb.open_filesto check if it should evict the AST or not. However, that means that all
project files will be rechecked after changing the open project files.
This PR prevents this by moving the AST eviction out of the
check_file_implfunction. This has the downsidethat it requires an extra
parsed_modulecall but thatshould be relatively cheap (we make thousends of those when checking a single file).
Test Plan
I verified that opening an other file doesn't result in re-checking every single project file.