[ty] Avoid stale diagnostics for open files diagnostic mode #19273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvmanila
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
dhruvmanila
added
server
|
MichaReiser
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where in
openFilesOnlydiagnostic mode, VS Code wouldn't clean up the diagnostics even though the server asked it to by sending an empty publish diagnostics.This is not the long-term solution but a quick fix. Ideally, the server would dynamically register for workspace diagnostics but that requires listening for
didChangeConfigurationnotification which I'm going to be working on with astral-sh/ty#82.Test Plan
Before
This uses the latest stable version of ty.
Screen.Recording.2025-07-11.at.08.54.30.mov
After
This uses the debug build of ty from this PR.
Screen.Recording.2025-07-11.at.08.55.06.mov