[ty] don't allow first-party code to shadow stdlib types module #19128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#741
The situation with shadowing
types
at runtime is a bit muddy. It's not a builtin module, and isn't explicitly non-shadowable. But in practice, it is typically imported very early in interpreter startup, and this means in most cases it practically can't be shadowed. Even in the scenarios where shadowing it is possible, this usually just causes interpreter startup to fail, due to trying to import things from it.Since shadowing it doesn't really work at runtime, and also causes problems in type-checking (since we try to import things from it implicitly), the simplest approach is just to not support shadowing it.
Neither mypy nor pyright support shadowing it. Mypy has a nice diagnostic specifically informing you that you are trying to shadow it and that doesn't work; I added a TODO for us to consider adding this in future.
Test Plan
Added an mdtest which stack-overflowed before this PR.