[ty] Fix panics when pulling types for various special forms that have the wrong number of parameters #18642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
force-pushed
the
alex/pulltypes-panics
branch
from
3408ccc to
64d2e16
Compare
carljm
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On
mainwe panic if we try to "pull types" for a file that includes a certain parameterized special form with the wrong number of arguments. This can cause unpredictable crashes in the playground, for example:Screen.Recording.2025-06-12.at.11.41.37.mov
Test Plan
Mdtests (which now pull types automatically if they don't have the
<!-- pull-types:skip -->directive in them, following #18539)