-
-
Notifications
You must be signed in to change notification settings - Fork 65
Document tip of using regex flags, regex: (?i)apple #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation update adding a second informational tip to the atomic rule guide demonstrating Rust-style inline regex flags (e.g., Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
website/guide/rule-config/atomic-rule.md (1)
164-170
: Fix linter warning, punctuation, and a typo; prefer a YAML example over a list item.Switch the dash list to a code block (resolves MD004), remove the extra space before the colon, and fix “as way as” → “as well as.” This also aligns with doc formatting elsewhere in this page.
-:::tip -You can use [Rust syntax for your regex flags](https://docs.rs/regex/latest/regex/#grouping-and-flags), such as : - -- `regex: "(?i)apple"` which will match Apple as way as apple or APPLE - -::: +:::tip +You can use [Rust‑style inline flags](https://docs.rs/regex/latest/regex/#grouping-and-flags), for example: + +```yaml +rule: + regex: "(?i)apple" +``` + +This matches Apple as well as apple or APPLE. +:::
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/guide/rule-config/atomic-rule.md
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
website/**/*.md
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
website/**/*.md
: Documentation should use clear, concise language
Include code examples for concepts in documentation
Test documentation examples in the playground when possible
Maintain consistent formatting across documentation pages
Files:
website/guide/rule-config/atomic-rule.md
🪛 markdownlint-cli2 (0.17.2)
website/guide/rule-config/atomic-rule.md
167-167: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Summary by CodeRabbit