Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 3, 2025

This PR adds proper GitHub Copilot custom instructions for working with catalog markdown files in the website/catalog/ directory, following the official GitHub documentation structure.

What's Fixed

The custom instructions file now follows the correct GitHub format:

  • Proper directory structure: Uses .github/instructions/ directory as required by GitHub
  • Correct filename: Uses .instructions.md naming convention instead of .instruction.md
  • Frontmatter format: Implements applyTo frontmatter with glob pattern targeting website/catalog/**/*.md

Instructions Provided

The catalog.instructions.md file provides comprehensive guidance for creating and managing ast-grep rule examples:

Complete Workflow (7 steps):

  1. Determine the programming language for the rule
  2. Choose between pattern or YAML format
  3. Use the rule-template.md as a foundation
  4. Include the rule in the language folder's index.md
  5. Ensure all required components are present
  6. Add clear, concise descriptions
  7. Handle fix rules with proper badges and diff sections

Key Features:

  • Format guidance: Clear distinction between pattern-based and YAML-based rules
  • Quality standards: Requirements for example code, playground links, descriptions, and proper formatting
  • Badge handling: Instructions for adding "Has Fix" badges to rules with fix capabilities
  • File conventions: Naming standards and include syntax for language index files
  • Example structure: Complete template showing proper markdown format

Benefits

GitHub Copilot will now provide contextual assistance specific to catalog development workflows, helping contributors create consistent, high-quality catalog entries that follow established conventions.

Fixes #808.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] add custom instruction for catalog Add GitHub Copilot custom instructions for catalog markdown files Aug 3, 2025
@HerringtonDarkholme HerringtonDarkholme marked this pull request as ready for review August 3, 2025 20:54
@Copilot Copilot AI requested a review from HerringtonDarkholme August 3, 2025 20:54
Copilot finished work on behalf of HerringtonDarkholme August 3, 2025 20:54
Copy link

coderabbitai bot commented Aug 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@HerringtonDarkholme HerringtonDarkholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the guide in
https://docs.github.com/en/enterprise-cloud@latest/copilot/how-tos/configure-custom-instructions/add-repository-instructions#creating-a-repository-custom-instructions-file


Using one or more .instructions.md files
Create the .github/instructions directory if it does not already exist.

Create one or more .instructions.md files, adding natural language instructions to the file(s).

Whitespace between instructions is ignored, so the instructions can be written as a single paragraph, each on a new line, or separated by blank lines for legibility.

Specify what files or directories the instructions apply to by adding applyTo frontmatter to the Markdown files, using glob syntax.


applyTo: "app/models/**/*.rb"

Add custom instructions here
To apply the instructions to all files, use the ** pattern.

- Create .github/instructions/ directory as per GitHub documentation
- Move content to catalog.instructions.md with proper frontmatter
- Add applyTo frontmatter with glob pattern for website/catalog/**/*.md
- Remove incorrectly placed catalog.instruction.md file

Follows the guidelines from:
https://docs.github.com/en/enterprise-cloud@latest/copilot/how-tos/configure-custom-instructions/add-repository-instructions

Co-authored-by: HerringtonDarkholme <[email protected]>
Copy link
Contributor Author

Copilot AI commented Aug 3, 2025

Please follow the guide in
https://docs.github.com/en/enterprise-cloud@latest/copilot/how-tos/configure-custom-instructions/add-repository-instructions#creating-a-repository-custom-instructions-file...

Fixed! I've restructured the custom instructions file to follow the GitHub guidelines:

  • Created .github/instructions/ directory
  • Moved content to catalog.instructions.md with proper frontmatter
  • Added applyTo: "website/catalog/**/*.md" frontmatter using glob syntax
  • Removed the incorrectly placed file

The structure now follows the official documentation you linked. Commit: 26f8b4d

@Copilot Copilot AI changed the title Add GitHub Copilot custom instructions for catalog markdown files Fix GitHub Copilot custom instructions file structure for catalog markdown files Aug 3, 2025
@Copilot Copilot AI requested a review from HerringtonDarkholme August 3, 2025 20:58
Copilot finished work on behalf of HerringtonDarkholme August 3, 2025 20:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR establishes proper GitHub Copilot custom instructions to assist with creating and managing ast-grep rule examples in the catalog. The change implements the correct GitHub directory structure and filename convention while providing comprehensive workflow guidance for catalog contributors.

Key Changes:

  • Creates GitHub Copilot custom instructions following official format requirements
  • Provides structured 7-step workflow for catalog rule creation
  • Establishes quality standards and formatting conventions for rule examples

@HerringtonDarkholme HerringtonDarkholme added this pull request to the merge queue Aug 3, 2025
Merged via the queue into main with commit b4ca76f Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add custom instruction for catalog
2 participants