Skip to content

Conversation

Hapshanko
Copy link
Contributor

Closes #24458

  1. Add if obj.status.observedGeneration == nil or obj.status.observedGeneration == obj.metadata.generation then to deal with the race condition where the resource is not yet updated yet, but Argo CD already set health based on a stale status.
  2. Update tests and add generation test.
  3. Add missing health.lua to SQLUser
    Note: These config connector resources have observedGeneration, but I still added a nil check to be on the safe side.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Hapshanko Hapshanko requested a review from a team as a code owner September 8, 2025 17:18
Copy link

bunnyshell bot commented Sep 8, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-tzwqqa.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-tzwqqa.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@Hapshanko Hapshanko force-pushed the configconnector-healthchecks branch from 96681ce to 82fbd6e Compare September 8, 2025 17:20
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@7829e2c). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #24459   +/-   ##
=========================================
  Coverage          ?   60.27%           
=========================================
  Files             ?      350           
  Lines             ?    59995           
  Branches          ?        0           
=========================================
  Hits              ?    36159           
  Misses            ?    20934           
  Partials          ?     2902           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hapshanko Hapshanko changed the title fix: GCP config connector healthcheck race condition with observedGeneration #24458 fix: GCP config connector healthchecks do not make use of existing observedGeneration #24458 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP ConfigConnector healthchecks not using observedGeneration
2 participants