Skip to content

feat(hydrator): parallelize repo-server calls (#24451) #24436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 9, 2025
Merged

feat(hydrator): parallelize repo-server calls (#24451) #24436

merged 5 commits into from
Sep 9, 2025

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Sep 6, 2025 •
edited
Loading

Closes #24451

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 6, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@7829e2c). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
controller/hydrator/hydrator.go 79.16% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #24436   +/-   ##
=========================================
  Coverage          ?   60.27%           
=========================================
  Files             ?      350           
  Lines             ?    60009           
  Branches          ?        0           
=========================================
  Hits              ?    36171           
  Misses            ?    20928           
  Partials          ?     2910

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev changed the title feat(hydrator): parrallelize repo-server calls feat(hydrator): parrallelize repo-server calls (#24451) Sep 8, 2025
@crenshaw-dev crenshaw-dev marked this pull request as ready for review September 8, 2025 18:14
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner September 8, 2025 18:14
@leoluz leoluz changed the title feat(hydrator): parrallelize repo-server calls (#24451) feat(hydrator): parallelize repo-server calls (#24451) Sep 8, 2025
leoluz
leoluz approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controller/hydrator/hydrator.go
}
paths := []*commitclient.PathDetails{pathDetails}

eg, ctx := errgroup.WithContext(context.Background())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting usage of errgroup. It seems that you are using it just to avoid having to do wg.Add(1)? In go 1.25 this baked directly in the sync package:
https://antonz.org/go-1-25/#go-wait-group-go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using it for the error handling and fail-fast context. I'm hoping those will make their way into the standard library soon as well.

@crenshaw-dev crenshaw-dev merged commit 8b2799c into argoproj:master Sep 9, 2025
29 checks passed
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
@crenshaw-dev @Mangaal
feat(hydrator): parallelize repo-server calls (argoproj#24451) (argop…
59017cd 
…roj#24436)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelize source hydrator manifest generation
2 participants
@crenshaw-dev @leoluz