fix: allow flags to be set when auto-sync is disabled (#24328)
#24380
+84
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: downfa11 <[email protected]>
Signed-off-by: downfa11 <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: downfa11 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24380 +/- ##
==========================================
+ Coverage 60.29% 60.37% +0.07%
==========================================
Files 350 350
Lines 59959 60038 +79
==========================================
+ Hits 36155 36247 +92
+ Misses 20909 20881 -28
- Partials 2895 2910 +15 ☔ View full report in Codecov by Sentry. |
agaudreault
requested changes
Sep 8, 2025
cmd/util/app_test.go
Outdated
| f.spec.SyncPolicy = nil | ||
| require.NoError(t, f.SetFlag("auto-prune", "true")) | ||
| require.NotNil(t, f.spec.SyncPolicy) | ||
| require.NotNil(t, f.spec.SyncPolicy.Automated) |
There was a problem hiding this comment.
missing an assert to validate that spec.SyncPolicy.Automated.Enabled is false`.
- It should be validated that if
enabled: true(or not nil), then setting the flag will keep enabled to true.
There was a problem hiding this comment.
In the current app_test.go, the logic causes one test to affect another.
I added a Reset() method to prevent them from interfering with one another.
Signed-off-by: downfa11 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes[#24328]
cmd/util/app.go: options like--auto-pruneare allowed to cases where auto-sync is disabled.cmd/util/app_test.go: a test added to validate the updated option.cmd/util/app.go,docs/user-guide/commands/*: examples like 'when sync is automated' updated.Checklist: