-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: Add preservePath option to proxy extension configuration #24312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add preservePath option to proxy extension configuration #24312
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, if not already done could you create an issue for what this PR fixes and link it to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, Could you also add something in the documentation for this new field and include the use case and how to set it?
5436d17
to
9d2ddce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24312 +/- ##
==========================================
+ Coverage 60.19% 60.21% +0.02%
==========================================
Files 348 348
Lines 59904 59911 +7
==========================================
+ Hits 36060 36078 +18
+ Misses 20954 20946 -8
+ Partials 2890 2887 -3 ☔ View full report in Codecov by Sentry. |
@pjiang-dev: Added to the docs, got the new test working and updated the PR description to reference the github issue. |
1555ce4
to
7d0b1de
Compare
b24563c
to
8e1ed2c
Compare
Signed-off-by: Alex Kattathra Johnson <[email protected]>
8e1ed2c
to
6f226c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending for enhancement triage/approval
Fixes #24311
Checklist: