Skip to content

Conversation

alex-kattathra-johnson
Copy link

@alex-kattathra-johnson alex-kattathra-johnson commented Aug 28, 2025

Fixes #24311

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@alex-kattathra-johnson alex-kattathra-johnson requested a review from a team as a code owner August 28, 2025 22:48
Copy link

bunnyshell bot commented Aug 28, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link
Contributor

@pjiang-dev pjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, if not already done could you create an issue for what this PR fixes and link it to this PR?

Copy link
Contributor

@pjiang-dev pjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, Could you also add something in the documentation for this new field and include the use case and how to set it?

@alex-kattathra-johnson alex-kattathra-johnson changed the title Add preservePath option to proxy extension configuration feat: Add preservePath option to proxy extension configuration Aug 29, 2025
@alex-kattathra-johnson alex-kattathra-johnson force-pushed the fixes-24311 branch 4 times, most recently from 5436d17 to 9d2ddce Compare August 29, 2025 23:56
@alex-kattathra-johnson alex-kattathra-johnson requested a review from a team as a code owner August 29, 2025 23:56
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.21%. Comparing base (1db5f2e) to head (7d0b1de).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24312      +/-   ##
==========================================
+ Coverage   60.19%   60.21%   +0.02%     
==========================================
  Files         348      348              
  Lines       59904    59911       +7     
==========================================
+ Hits        36060    36078      +18     
+ Misses      20954    20946       -8     
+ Partials     2890     2887       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-kattathra-johnson
Copy link
Author

@pjiang-dev: Added to the docs, got the new test working and updated the PR description to reference the github issue.

@alex-kattathra-johnson alex-kattathra-johnson force-pushed the fixes-24311 branch 2 times, most recently from 1555ce4 to 7d0b1de Compare August 30, 2025 02:00
@pjiang-dev pjiang-dev added the ready-for-review An approver should give a final review and merge the PR label Sep 2, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Sep 2, 2025
@alex-kattathra-johnson alex-kattathra-johnson force-pushed the fixes-24311 branch 2 times, most recently from b24563c to 8e1ed2c Compare September 2, 2025 13:13
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending for enhancement triage/approval

@github-project-automation github-project-automation bot moved this from Ready for final review to Changes Requested in Argo CD Review Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Option to preservePath in proxy extension
3 participants