-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: added --cascade flag support for handling application set deletion #18614 #18770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…etion argoproj#18614 Signed-off-by: nikzayn <[email protected]>
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a flag, we are using in command.Flags
Signed-off-by: pasha-codefresh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Where is the logic that uses the new param and performs the cascading deletion based on it?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18770 +/- ##
==========================================
+ Coverage 55.93% 55.95% +0.01%
==========================================
Files 322 322
Lines 44673 44677 +4
==========================================
+ Hits 24989 24998 +9
+ Misses 17092 17091 -1
+ Partials 2592 2588 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: pasha-codefresh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your change again. In order to pass cascade option to applicationset controller, you need pass it applicationset.ApplicationSetDeleteRequest. But also add support on server side for it
Checklist:
argocd appset delete