Skip to content

Conversation

nikzayn
Copy link
Contributor

@nikzayn nikzayn commented Jun 22, 2024

Checklist:

@nikzayn nikzayn requested review from a team as code owners June 22, 2024 18:48
Copy link

bunnyshell bot commented Jun 22, 2024

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

Copy link

bunnyshell bot commented Jun 22, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Contributor Author

@nikzayn nikzayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a flag, we are using in command.Flags

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Where is the logic that uses the new param and performs the cascading deletion based on it?

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (1e359c8) to head (e8d8adc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/applicationset.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18770      +/-   ##
==========================================
+ Coverage   55.93%   55.95%   +0.01%     
==========================================
  Files         322      322              
  Lines       44673    44677       +4     
==========================================
+ Hits        24989    24998       +9     
+ Misses      17092    17091       -1     
+ Partials     2592     2588       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: pasha-codefresh <[email protected]>
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your change again. In order to pass cascade option to applicationset controller, you need pass it applicationset.ApplicationSetDeleteRequest. But also add support on server side for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants