fix: prevent deadlock #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argoproj-labs#710. While migrating from an older version using sdkv2 to terraform-plugin-framework may need to recalculate the computed attributes, it should definitely not deadlock in the meantime. Added a test where we create a repository using `7.8.0`, and then update it using the current version of this provider. Whereas before this deadlocked, it now updates as intended, and once this initial migration update has been done there is no state diff afterwards. Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
requested review from
oboukili,
onematchfox,
the-technat and
mkilchhofer
as code owners
Signed-off-by: Blake Pettersson <[email protected]>
the-technat
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #710. While migrating from an older version using sdkv2 to terraform-plugin-framework may need to recalculate the computed attributes, it should definitely not deadlock in the meantime.
Added a test where we create a repository using
7.8.0, and then update it using the current version of this provider. Whereas before this deadlocked, it now updates as intended, and once this initial migration update has been done there is no state diff afterwards.