chore: set defaults in testmain #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the default configuration in one place, and at the same time allows for acceptance tests to not to have to use the make targets to get the default values set (useful in e.g the IDE). This also flips `USE_TESTCONTAINERS` to have a default of `true` (for now we don't do that in CI). This is something which can be discussed to see if that is desired by others. Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
requested review from
oboukili,
onematchfox,
the-technat and
mkilchhofer
as code owners
the-technat
approved these changes
Aug 13, 2025
* add new line when printing * inline `runTestSuite` logic Signed-off-by: Blake Pettersson <[email protected]>
|
Thank you @the-technat! 🙏 |
blakepettersson
added a commit
to blakepettersson/terraform-provider-argocd
that referenced
this pull request
Aug 20, 2025
This should have been a part of argoproj-labs#706. Signed-off-by: Blake Pettersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the default configuration in one place, and at the same time allows for acceptance tests to not to have to use the make targets to get the default values set (useful in e.g the IDE).
This also flips
USE_TESTCONTAINERSto have a default oftrue(for now we don't do that in CI). This is something which can be discussed to see if that is desired by others.