chore: preload argocd before running testcontainer tests #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running this locally I got a few tests that were persistently failing. It turned out to be because pulling the argocd image was slow, timing out the test init. Now we ensure that the image is pulled before performing `kubectl wait`, so that we only need to wait for the pods to be ready. Signed-off-by: Blake Pettersson <[email protected]>
blakepettersson
requested review from
oboukili,
onematchfox,
the-technat and
mkilchhofer
as code owners
the-technat
approved these changes
Aug 1, 2025
|
Makes sense to me |
Signed-off-by: Blake Pettersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running this locally I got a few tests that were persistently failing. It turned out to be because pulling the argocd image was slow, timing out the test init. Now we ensure that the image is pulled before performing
kubectl wait, so that we only need to wait for the pods to be ready.