Skip to content

Fix return value of NTPClient::update #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Fix return value of NTPClient::update #56

merged 1 commit into from
Sep 19, 2019

Conversation

bitsy
Copy link
Contributor

@bitsy bitsy commented Sep 17, 2018

The NTPClient method update() has been changed to only return "TRUE" after a successful update. The following conditions return "FALSE":

  • Interval duration requirement not met
  • forceUpdate() times out

@bitsy
Update NTPClient.cpp
712c58c 
The NTPClient method update() has been changed to only return "TRUE" after a successful update. The following conditions return "FALSE":
- Interval duration requirement not met
- forceUpdate() times out
bperkins011
bperkins011 reviewed Sep 12, 2019
View reviewed changes
Copy link

@bperkins011 bperkins011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be committed? The change makes more sense than the original code.
thx

@aentinger aentinger merged commit 97cdcd7 into arduino-libraries:master Sep 19, 2019
@aentinger aentinger changed the title Update NTPClient.cpp Fix return value of NTPClient::update Sep 19, 2019
@aentinger aentinger mentioned this pull request Sep 19, 2019
Closed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 8, 2024
@per1234 per1234 mentioned this pull request Dec 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bperkins011 bperkins011 bperkins011 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bitsy @per1234 @bperkins011 @afrixx @aentinger