fix(engine): feedback deadlock issues #4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR disables the feedback functionality within the engine to prevent a deadlock as explained in the commit message.
- The feedback-related code has been commented out to avoid potential deadlock scenarios.
- The overall engine behavior is modified to stop feeding back events.
NDStrahilevitz
force-pushed
the
no_feedback
branch
2 times, most recently
from
9cfd2e5 to
77d211e
Compare
NDStrahilevitz
changed the title
NDStrahilevitz
force-pushed
the
no_feedback
branch
2 times, most recently
from
0905327 to
d867f28
Compare
NDStrahilevitz
force-pushed
the
no_feedback
branch
from
d867f28 to
048db32
Compare
Feedback from findings back into the rules engine could cause a deadlock. This is because the engine would eventually block on trying to to send a new event to the feedbacking signature. This would cause a deadlock there - propagating back to the engine and pipeline in general. This does not occur in analyze mode - likely due to less stress in that mode. Introduce a mode field to the engine config to allow distinction between tracee-rules, single binary and analyze modes. The feedback logic which is implemented in the engine is only relevant for analyze mode. In single binary mode, we rely on the pipeline to handle the feedback.
Avoid deadlocks by writing first into a from file channel buffer, then into the engine.
NDStrahilevitz
force-pushed
the
no_feedback
branch
from
048db32 to
d71aff0
Compare
NDStrahilevitz
changed the title
NDStrahilevitz
changed the title
yanivagman
approved these changes
Jun 24, 2025
|
/fast-forward |
NDStrahilevitz
added a commit
to NDStrahilevitz/tracee
that referenced
this pull request
Jun 24, 2025
Feedback from findings back into the rules engine could cause a deadlock. This is because the engine would eventually block on trying to to send a new event to the feedbacking signature. This would cause a deadlock there - propagating back to the engine and pipeline in general. This does not occur in analyze mode - likely due to less stress in that mode. Introduce a mode field to the engine config to allow distinction between tracee-rules, single binary and analyze modes. The feedback logic which is implemented in the engine is only relevant for analyze mode. In single binary mode, we rely on the pipeline to handle the feedback. commit a86e656 (main), cherry-pick
NDStrahilevitz
added a commit
to NDStrahilevitz/tracee
that referenced
this pull request
Jun 24, 2025
Avoid deadlocks by writing first into a from file channel buffer, then into the engine. commit d71aff0 (main), cherry-pick
geyslan
pushed a commit
that referenced
this pull request
Jun 30, 2025
Feedback from findings back into the rules engine could cause a deadlock. This is because the engine would eventually block on trying to to send a new event to the feedbacking signature. This would cause a deadlock there - propagating back to the engine and pipeline in general. This does not occur in analyze mode - likely due to less stress in that mode. Introduce a mode field to the engine config to allow distinction between tracee-rules, single binary and analyze modes. The feedback logic which is implemented in the engine is only relevant for analyze mode. In single binary mode, we rely on the pipeline to handle the feedback. commit a86e656 (main), cherry-pick
geyslan
pushed a commit
that referenced
this pull request
Jun 30, 2025
Avoid deadlocks by writing first into a from file channel buffer, then into the engine. commit d71aff0 (main), cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
048db32 fix(analyze): split input channel
316ddfe fix(engine): restrict internal feedback to analyze
048db32 fix(analyze): split input channel
316ddfe fix(engine): restrict internal feedback to analyze
2. Explain how to test it
Confirmed in internal e2e - submit failures with mass verification failure stopped.
3. Other comments