[Hot State] Prepare for having all checkpoint indices in StateUpdateRefs #17548
+270
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wqfish
force-pushed
the
pr17548
branch
2 times, most recently
from
27e8a8c to
106db82
Compare
wqfish
changed the title
wqfish
force-pushed
the
pr17548
branch
2 times, most recently
from
f58709d to
16cb7ce
Compare
wqfish
requested review from
lightmark,
grao1991,
gelash,
zekun000,
sasha8 and
danielxiangzl
as code owners
This was referenced Sep 11, 2025
Right now `StateUpdateRefs` has the most recent checkpoint. In order to compute hot state, we need to perform eviction at the end of each block. When applying to state sync, this means that we need to know all the checkpoints and not just the most recent one. Also refactored the code a bit such that `extract_retries_and_discards` is simply responsible for extracting retries and discards, not for computing `has_reconfig`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
StateUpdateRefshas the most recent checkpoint. In order to computehot state, we need to perform eviction at the end of each block. When applying
to state sync, this means that we need to know all the checkpoints and not just
the most recent one.
Also refactored the code a bit such that
extract_retries_and_discardsissimply responsible for extracting retries and discards, not for computing
has_reconfig.Stack created with Sapling. Best reviewed with ReviewStack.