Skip to content

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Apr 11, 2025

Description

This PR adds const qualifier to accessors to AccountAddress inner data and a const constructor from u64.

How Has This Been Tested?

Added test case.

Key Areas to Review

This PR doesn't add non-trivial changes that can break existing code.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Apr 11, 2025

⏱️ 7s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 4s 🟥
permission-check 3s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label May 27, 2025
@github-actions github-actions bot removed the Stale label May 28, 2025
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jul 12, 2025
@github-actions github-actions bot removed the Stale label Jul 13, 2025
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Aug 28, 2025
@github-actions github-actions bot removed the Stale label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant