Skip to content

Fix generated shell completion script handling of repeating & non-repeating positional arguments, flags & options #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix generated shell completion script handling of repeating & non-repeating positional arguments, flags & options #808

wants to merge 7 commits into from

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Sep 13, 2025 •
edited
Loading

Fix generated shell completion script handling of repeating & non-repeating positional arguments, flags & options.

Also fix an unrelated swift-format violation & DocC typos in Flag.swift.

Resolve #806

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@rgoldberg
Remove extraneous back ticks in DocC in Flag.swift.
c010368 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Ignore spurious "Begin Documentation Comment With One Line Summary" s…
66def22 
…wift-format violation.

swift-format seems to have a bug.

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Complete repeatable positional instances after the first in bash.
e76e234 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Complete repeatable positional instances after the first in fish.
98212a4 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Only complete positionals through the first repeating positional in zsh.
bdfd69a 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Complete repeatable flag & option instances after the first in bash.
7c5fc8d 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Complete non-repeatable flag & option instances only once in fish.
c819a12 
Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg changed the title 806 repeating arguments Fix generated shell completion script handling of repeating & non-repeating positional arguments, flags & options Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 Awaiting requested review from natecook1000 natecook1000 is a code owner

@rauhul rauhul Awaiting requested review from rauhul rauhul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shell completion scripts variously do not properly handle repeating and/or non-repeating positional arguments, flags, or options
1 participant
@rgoldberg