feat: Added docstring for macOS screenrecord option #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Feb 7, 2021
| The default value is 4. You can increase the bit rate to improve video quality, | ||
| but doing so results in larger movie files. | ||
| fps (int): [macOS only] The count of frames per second in the resulting video. |
There was a problem hiding this comment.
ah, Python gives arguments as kewrgas in a method.
|
The screen recording is also available in Windows: https://github.com/appium/appium-windows-driver/blob/master/lib/commands/record-screen.js |
|
|
||
|
|
||
| class TestExecuteScript(BaseTestCase): | ||
| def test_sending_custom_keys(self) -> None: |
There was a problem hiding this comment.
it is good to have these tests, but they are not going to work in CI env, because the necessary accessibility permissions are missing there
mykola-mokhnach
approved these changes
Feb 7, 2021
|
I'll handle it in another PR. (e.g. by creating table for user friendly)
|
mykola-mokhnach
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
from appium/java-client#1439
Other changes
Added functional tests for macOS (from https://github.com/appium/appium-mac2-driver#examples )