Skip to content

refactor: Replace Guava HttpHeaders with Selenium HttpHeader #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

refactor: Replace Guava HttpHeaders with Selenium HttpHeader #2151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/io/appium/java_client/internal/filters/AppiumUserAgentFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@

package io.appium.java_client.internal.filters;

import com.google.common.net.HttpHeaders;
import io.appium.java_client.internal.Config;
import org.openqa.selenium.remote.http.AddSeleniumUserAgent;
import org.openqa.selenium.remote.http.Filter;
import org.openqa.selenium.remote.http.HttpHandler;
import org.openqa.selenium.remote.http.HttpHeader;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;
Expand Down Expand Up @@ -81,7 +81,9 @@ public static String buildUserAgent(@Nullable String userAgent) {
@Override
public HttpHandler apply(HttpHandler next) {
return req -> {
req.setHeader(HttpHeaders.USER_AGENT, buildUserAgent(req.getHeader(HttpHeaders.USER_AGENT)));
var originalUserAgentHeader = req.getHeader(HttpHeader.UserAgent.getName());
var newUserAgentHeader = buildUserAgent(originalUserAgentHeader);
req.setHeader(HttpHeader.UserAgent.getName(), newUserAgentHeader);
return next.execute(req);
};
}
Expand Down