feat: add pollDelay mechanism into AppiumFluentWait #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroMiccoli
requested review from
mykola-mokhnach,
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
valfirst
requested changes
Feb 14, 2024
|
@mykola-mokhnach is there something else I need to do for merging this PR? |
valfirst
requested changes
Feb 15, 2024
Co-authored-by: Valery Yatsynovich <[email protected]>
|
it looks like CI became unhappy |
Yes, a little bit of patience ;-). We check it as soon as there is some free time |
|
A length rule failed in the pipeline. What do you use for checking the rules? Do you use the Google standard styling rules? |
| .orElseGet(() -> "waiting for " + isTrue); | ||
|
|
||
| var timeoutMessage = String.format( | ||
| "Expected condition failed: %s (tried for %s millis with an interval of %s millis)", |
mykola-mokhnach
approved these changes
Feb 16, 2024
valfirst
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
These changes will allow the
AppiumFluentWaitto sleep for a definedpollDelaybefore starting to verify the condition is true. It includes a little refactor to theuntilmethod, so it will be more readable.