refactor: Make sure we only write W3C payload into create session command #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
valfirst
reviewed
Oct 22, 2021
Comment on lines
+44
to
+49
| return possiblyInvalidCapabilities.asMap().entrySet().stream() | ||
| .map((entry) -> ACCEPTED_W3C_PATTERNS.test(entry.getKey()) | ||
| ? entry | ||
| : new AbstractMap.SimpleEntry<>( | ||
| String.format("%s%s", APPIUM_PREFIX, entry.getKey()), entry.getValue())) | ||
| .collect(ImmutableMap.toImmutableMap(Map.Entry::getKey, Map.Entry::getValue)); |
There was a problem hiding this comment.
Suggested change
| return possiblyInvalidCapabilities.asMap().entrySet().stream() | |
| .map((entry) -> ACCEPTED_W3C_PATTERNS.test(entry.getKey()) | |
| ? entry | |
| : new AbstractMap.SimpleEntry<>( | |
| String.format("%s%s", APPIUM_PREFIX, entry.getKey()), entry.getValue())) | |
| .collect(ImmutableMap.toImmutableMap(Map.Entry::getKey, Map.Entry::getValue)); | |
| return possiblyInvalidCapabilities.asMap().entrySet().stream() | |
| .collect(ImmutableMap.toImmutableMap( | |
| entry -> ACCEPTED_W3C_PATTERNS.test(entry.getKey()) ? entry.getKey() : APPIUM_PREFIX + entry.getKey(), | |
| Map.Entry::getValue | |
| )); |
?
There was a problem hiding this comment.
np, I could add it in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Selenium4 declares that it only supports W3C and nevertheless still writes JWP's
desiredCapabilitiesinto createSession JSON. We should eliminate that.Types of changes