-
-
Notifications
You must be signed in to change notification settings - Fork 768
feat: allow to add custom command dynamically #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b5fbe51
b0de4e4
075cc17
0165dc0
2ad38e1
062a261
f46e1f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -241,6 +241,9 @@ public Response execute(Command command) throws WebDriverException { | |
} | ||
}); | ||
} | ||
if (getAdditionalCommands().containsKey(command.getName())) { | ||
super.defineCommand(command.getName(), getAdditionalCommands().get(command.getName())); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we verify if the defined command does not override an existing one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At server side of plugin, we allow to override the behaviour of an Appium command though the path of command remain same. Keep the client side in line with server, I would like to allow client plugins also to override the existing command in same path with a different behaviour. |
||
} | ||
|
||
Response response; | ||
try { | ||
|
Uh oh!
There was an error while loading. Please reload this page.