Skip to content

fix: Set appropriate fluent wait timeouts #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix: Set appropriate fluent wait timeouts #1316

merged 1 commit into from
Mar 17, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Mar 16, 2020 •
edited
Loading

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

...this is the nice example of why to always use dedicated types for different time units

https://dev.azure.com/srinivasansekar/java-client/_build/results?buildId=376&view=logs&j=dcf5f1f5-2eb6-5586-dc7f-e40285fb9e33&t=001cc609-8f94-5735-fd9e-04c1a9cbbffb

@mykola-mokhnach mykola-mokhnach merged commit 820dbb7 into master Mar 17, 2020
@mykola-mokhnach mykola-mokhnach deleted the timeouts branch March 17, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @KazuCocoa @SrinivasanTarget