Skip to content

Add apple tvOS platform constant #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2019
Merged

Add apple tvOS platform constant #1142

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd0a556
Merge pull request #1 from appium/master
ajeeshvl May 10, 2019
f3d7b33
tvOS driver implementation
ajeeshvl May 10, 2019
da0face
clean up
ajeeshvl May 11, 2019
c7c8d08
removed tvos driver
ajeeshvl May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/io/appium/java_client/remote/MobilePlatform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ public interface MobilePlatform {
String IOS = "iOS";
String FIREFOX_OS = "FirefoxOS";
String WINDOWS = "Windows";
String TVOS = "tvOS";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have it inside AutomationName interface instead?

Copy link
Member

@KazuCocoa KazuCocoa May 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I do not think so in this case.
It confuses users a bit since when we use tvOS, the capability should be like:

...
automationName: 'xcuites', # AutomationName.IOS_XCUI_TEST
platformName: 'tvOS'      # AutomationName.IOS_TVOS vs MobilePlatform.TVOS (or APPLE_TVOS is proper?)
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike youiengine tvos uses xcuitest as automation name. I still think having a TVOSdriver would also be helpful. That would avoid confusion for users around what capability needs to be used for tvos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion about the new class.
I would respect @mykola-mokhnach, @saikrishna321 and @SrinivasanTarget

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say not to have TVOSDriver class. We should just document what capability to use for TVOS.

}