Skip to content

Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. (#3159) #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2025
Merged

Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. (#3159) #3462

merged 3 commits into from
May 25, 2025

Conversation

JWT007
Copy link
Contributor

@JWT007 JWT007 commented Feb 12, 2025

(#3159)

This should fix a potential NPE in AsyncWaitStrategyFactoryConfig if the builder 'class' field is not set or set to null/empty string.

  • added notEmpty assert to Builder setFactoryClassName
  • changed notNull to notEmpty assert to AsyncWaitStrategyFactoryConfig constructor.
  • added changelog XML file. (2.25.0)
  • added new tests to AsyncWaitStrategyFactoryConfigTest

@ppkarwasz ppkarwasz linked an issue Feb 16, 2025 that may be closed by this pull request
AsyncWaitStrategyFactoryConfig - potential NPE when creating programatically #3159
Closed
@JWT007
Copy link
Contributor Author

JWT007 commented Feb 16, 2025

@ppkarwasz moved changelog to .2.x.x per other PR notes

@ppkarwasz ppkarwasz added this to the 2.25.0 milestone Apr 13, 2025
@ppkarwasz
Copy link
Contributor

@JWT007, could you resign the commits and merge this?

@ppkarwasz ppkarwasz force-pushed the bugfix/LOG4J-3159 branch from 7ad6736 to 246f848 Compare May 25, 2025 13:41
@ppkarwasz ppkarwasz enabled auto-merge (squash) May 25, 2025 13:43
@ppkarwasz ppkarwasz merged commit f53f656 into apache:2.x May 25, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker May 25, 2025
@github-actions GitHub Actions
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@JWT007 JWT007

Labels
None yet
Projects
Log4j bug tracker
Status: Done
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

AsyncWaitStrategyFactoryConfig - potential NPE when creating programatically
2 participants
@JWT007 @ppkarwasz