Skip to content

Add requiresLocation function for AsyncAppender (#3257) #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add requiresLocation function for AsyncAppender (#3257) #3260

merged 1 commit into from
Jan 6, 2025

Conversation

eldwrjwt
Copy link
Contributor

@eldwrjwt eldwrjwt commented Dec 1, 2024

Fix #3257

  • Add requiresLocation implementation for AsyncAppender

@eldwrjwt eldwrjwt mentioned this pull request Dec 1, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024 •
edited
Loading

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz ppkarwasz self-assigned this Dec 4, 2024
ppkarwasz
ppkarwasz approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldwrjwt,

LGTM, thanks for your contribution.

@ppkarwasz ppkarwasz mentioned this pull request Jan 6, 2025
Open
27 tasks
@ppkarwasz ppkarwasz merged commit 1cbce56 into apache:2.x Jan 6, 2025
9 checks passed
jvz pushed a commit that referenced this pull request Jul 30, 2025
@eldwrjwt @jvz
Support AsyncAppender::requiresLocation
ea640be 
This is a port of #3260 to
3.x. This addresses #3257.
@jvz jvz mentioned this pull request Jul 30, 2025
Merged
jvz added a commit that referenced this pull request Aug 1, 2025
@jvz @eldwrjwt
Support AsyncAppender::requiresLocation (#3862)
e8c86e2 
* Support `AsyncAppender::requiresLocation`

This is a port of #3260 to
3.x. This addresses #3257.

* Remove unneeded file

---------

Co-authored-by: eldwrjwt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@ppkarwasz ppkarwasz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File line numbers are not printed for the failover appender when using AsyncLoggerContextSelector
2 participants
@eldwrjwt @ppkarwasz