MINOR: Small cleanups in clients #20530
Open
+59
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
force-pushed
the
clients-cleanups
branch
from
69ed804 to
768b31b
Compare
chia7712
reviewed
Sep 12, 2025
| @@ -202,7 +202,7 @@ private void handlePartitionError( | |||
| public Map<TopicPartition, Throwable> handleUnsupportedVersionException( | |||
| int brokerId, UnsupportedVersionException exception, Set<TopicPartition> keys | |||
| ) { | |||
| log.warn("Broker " + brokerId + " does not support MAX_TIMESTAMP offset specs"); | |||
| log.warn("Broker {} does not support MAX_TIMESTAMP offset specs", brokerId); | |||
There was a problem hiding this comment.
That is quite interesting. Right now it only deals with MAX_TIMESTAMP, while other timestamp placeholders are just unused. I think it is okay to keep the change for now, and I will follow up with a JIRA for the rest
There was a problem hiding this comment.
| @@ -74,7 +74,7 @@ public void testStringConversion() { | |||
|
|
|||
| String zeroIdString = Uuid.ZERO_UUID.toString(); | |||
|
|
|||
| assertEquals(Uuid.fromString(zeroIdString), Uuid.ZERO_UUID); | |||
| assertEquals(Uuid.ZERO_UUID, Uuid.fromString(zeroIdString)); | |||
| } | |||
|
|
|||
| @RepeatedTest(value = 100, name = RepeatedTest.LONG_DISPLAY_NAME) | |||
There was a problem hiding this comment.
Looks like lines 84 and 85 run into the same issue as well
assertNotEquals(randomID, Uuid.ZERO_UUID);
assertNotEquals(randomID, Uuid.METADATA_TOPIC_ID);
frankvicky
reviewed
Sep 14, 2025
| @@ -279,7 +279,7 @@ public void testSearch() throws IOException { | |||
| * Test that the message set iterator obeys start and end slicing | |||
| */ | |||
| @Test | |||
| public void testIteratorWithLimits() throws IOException { | |||
| public void testIteratorWithLimits() { | |||
There was a problem hiding this comment.
Some of the FileRecords are not closed during the test; should we also clean them?
L368, L382
| @@ -46,8 +46,8 @@ public void testSameRackSelector() { | |||
| ReplicaSelector selector = new RackAwareReplicaSelector(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.