KAFKA-19683: Remove dead tests and modify tests in TaskManagerTest [1/N] #20501
+39
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
shashankhs11
commented
Sep 8, 2025
| @@ -1853,14 +1812,20 @@ public void shouldReleaseLockForUnassignedTasksAfterRebalanceWithStateUpdater() | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldReportLatestOffsetAsOffsetSumForRunningTask() throws Exception { | |||
There was a problem hiding this comment.
as suggested in #19275 (comment)
shashankhs11
commented
Sep 8, 2025
| final StreamTask runningStatefulTask = statefulTask(taskId00, taskId00ChangelogPartitions) | ||
| .inState(State.RUNNING).build(); | ||
| final StreamTask restoringStatefulTask = statefulTask(taskId01, taskId01ChangelogPartitions) | ||
| .inState(State.RESTORING).build(); | ||
| final StandbyTask restoringStandbyTask = standbyTask(taskId02, taskId02ChangelogPartitions) | ||
| .inState(State.RUNNING).build(); | ||
| final long changelogOffsetOfRunningTask = 42L; | ||
| final long changelogOffsetOfRunningTask = Task.LATEST_OFFSET; |
There was a problem hiding this comment.
as suggested in #19275 (comment)
shashankhs11
commented
Sep 8, 2025
| @@ -1943,14 +1908,26 @@ public void shouldComputeOffsetSumForRunningStatefulTaskAndRestoringTaskWithStat | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldSkipUnknownOffsetsWhenComputingOffsetSum() throws Exception { | |||
There was a problem hiding this comment.
as suggested in #19275 (comment)
shashankhs11
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up test code in TaskManagerTest by removing dead tests and adding new ones to improve test coverage and maintainability.
- Removes three obsolete test methods that are no longer needed
- Adds a new utility method for setting up TaskManager instances
- Refactors two existing test methods to use a more direct testing approach with mocked dependencies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@shashankhs11 please rebase this on trunk, CI keeps failing on flaky tests that are already fixed |
shashankhs11
force-pushed
the
KAFKA-19683
branch
from
141e09a to
d58bbe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of cleaning up of the tests in
TaskManagerTestReviewers: Lucas Brutschy [email protected]