KAFKA-17941: Fix TransactionStateManager handling of empty batch when loading transaction metadata #17688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Thanks @vincent81jiang
Please leave a description and let's make sure tests pass :)
@jolshan, thanks for the review. Description updated. |
junrao
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
@vincent81jiang : Thanks for the PR. LGTM
I added a comment in #17193 (comment) to reduce the number of empty batches. But we can follow up on that separately.
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…saction metadata (apache#17688) When loading transaction metadata from a transaction log partition, if the partition contains a segment ending with an empty batch, "currOffset" update logic at will be skipped for the last batch. Since "currOffset" is not advanced to next offset of last batch properly, TransactionStateManager.loadTransactionMetadata method will be stuck in the "while" loop. This change fixes the issue by updating "currOffset" after processing each batch, whether the batch is empty or not. Reviewers: Justine Olshan <[email protected]>, Jun Rao <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…saction metadata (apache#17688) When loading transaction metadata from a transaction log partition, if the partition contains a segment ending with an empty batch, "currOffset" update logic at will be skipped for the last batch. Since "currOffset" is not advanced to next offset of last batch properly, TransactionStateManager.loadTransactionMetadata method will be stuck in the "while" loop. This change fixes the issue by updating "currOffset" after processing each batch, whether the batch is empty or not. Reviewers: Justine Olshan <[email protected]>, Jun Rao <[email protected]>
CalvinConfluent
pushed a commit
to CalvinConfluent/kafka
that referenced
this pull request
Sep 12, 2025
…saction metadata (apache#17688) When loading transaction metadata from a transaction log partition, if the partition contains a segment ending with an empty batch, "currOffset" update logic at will be skipped for the last batch. Since "currOffset" is not advanced to next offset of last batch properly, TransactionStateManager.loadTransactionMetadata method will be stuck in the "while" loop. This change fixes the issue by updating "currOffset" after processing each batch, whether the batch is empty or not. Reviewers: Justine Olshan <[email protected]>, Jun Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading transaction metadata from a transaction log partition, if the partition contains a segment ending with an empty batch, "currOffset" update logic at will be skipped for the last batch. Since "currOffset" is not advanced to next offset of last batch properly, TransactionStateManager.loadTransactionMetadata method will be stuck in the "while" loop.
This change fixes the issue by updating "currOffset" after processing each batch, whether the batch is empty or not.