Skip to content

chore: make Transaction cloneable #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

chore: make Transaction cloneable #1474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70f963
chore: make cloneable
dentiny Jun 28, 2025
b3ee3ee
Merge branch 'main' into hjiang/make-transaction-clonable
liurenjie1024 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/iceberg/src/transaction/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ use crate::transaction::upgrade_format_version::UpgradeFormatVersionAction;
use crate::{Catalog, TableCommit, TableRequirement, TableUpdate};

/// Table transaction.
#[derive(Clone)]
pub struct Transaction {
table: Table,
actions: Vec<BoxedTransactionAction>,
Expand Down Expand Up @@ -154,7 +155,7 @@ impl Transaction {
pub async fn commit(mut self, catalog: &dyn Catalog) -> Result<Table> {
if self.actions.is_empty() {
// nothing to commit
return Ok(self.table.clone());
return Ok(self.table);
}

self.do_commit(catalog).await
Expand Down
Loading