fix: fix rewrite_not to process complex nested not #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
fix_manifest_filter
branch
from
bda2afc to
2efe39a
Compare
ZENOTME
changed the title
ZENOTME
force-pushed
the
fix_manifest_filter
branch
2 times, most recently
from
3f1efa1 to
5dd53e6
Compare
ZENOTME
force-pushed
the
fix_manifest_filter
branch
2 times, most recently
from
b7bf0d3 to
197367b
Compare
Comment on lines
66
to
69
| Ok(Predicate::Unary(UnaryExpression::new( | ||
| PredicateOperator::IsNull, | ||
| reference.clone(), | ||
| ))) |
There was a problem hiding this comment.
We should just return predicate.clone() here?
crates/iceberg/src/expr/predicate.rs
Outdated
| @@ -1466,4 +1447,29 @@ mod tests { | |||
| assert_eq!(&format!("{bound_expr}"), r#"True"#); | |||
| test_bound_predicate_serialize_diserialize(bound_expr); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_rewrite_not_deeply_nested() { | |||
There was a problem hiding this comment.
I think it's better to move this test to rewrite_not?
ZENOTME
force-pushed
the
fix_manifest_filter
branch
from
197367b to
b9de84d
Compare
liurenjie1024
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Original
rewrite_notcan't process nested not expression likenot(not(not(bar > 1000))).This PR uses visitor to implement rewrite_not so that it can process nested not expression recursively.Are these changes tested?
unit test