bug(storage-azdls): Fix inferred WASB endpoint #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DerGut <[email protected]>
Signed-off-by: DerGut <[email protected]>
Signed-off-by: Jannik Steinmann <[email protected]>
|
LGTM. cc @Xuanwo Would you take a look? |
Xuanwo
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
I tested again fileIO operations with the
wasbs://scheme, and the current implementation mistakenly used theblobendpoint which is lacking the ADLS APIs.What changes are included in this PR?
The code now always uses the
dfsendpoint, regardless of whether a user passeswasb[s]://orabfs[s]://. Because theAzureStoragePath::storage_servicefield isn't read, I've removed it.Are these changes tested?
Yes, I added a new unit test for the
AzureStoragePath::endpointmethod.