-
Notifications
You must be signed in to change notification settings - Fork 358
Add Snapshots table metadata #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woot! this is great, first metadata table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is a great start for metadata table! @Fokko.
Just have one question: I was thinking if later we need those metadata table classes, StaticTableScan
, and StaticDataTask
like what Java did. These may become useful when other engines (Daft, Ray) wants to represent the metadata tables in their dataframe. But since the metadata tables are normally not very large so using pyarrow
as a bridge may be enough?
@Fokko Can we merge this? I am almost done with "Files" table, so I can rebase my code before creating a PR. |
I'm open for that, but I would like to defer that to a later PR. I don't like the hard dependency on PyArrow, and would love to get rid of that, but I'm not sure what the best format is then. An Arrow table can be used in most engines without any copying. I'll move this forward so @Gowthami03B can continue her work. |
Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 3.14.1 to 3.15.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/releases">pytest-mock's releases</a>.</em></p> <blockquote> <h2>v3.15.0</h2> <p><em>2025-09-04</em></p> <ul> <li>Python 3.8 (EOL) is no longer supported.</li> <li><a href="https://redirect.github.com/pytest-dev/pytest-mock/pull/524">#524</a>: Added <code>spy_return_iter</code> to <code>mocker.spy</code>, which contains a duplicate of the return value of the spied method if it is an <code>Iterator</code>.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst">pytest-mock's changelog</a>.</em></p> <blockquote> <h2>3.15.0</h2> <p><em>2025-09-04</em></p> <ul> <li>Python 3.8 (EOL) is no longer supported.</li> <li><code>[#524](pytest-dev/pytest-mock#524) <https://github.com/pytest-dev/pytest-mock/pull/524></code>_: Added <code>spy_return_iter</code> to <code>mocker.spy</code>, which contains a duplicate of the return value of the spied method if it is an <code>Iterator</code>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/90b29f89e2086c139a7b4fea89202faa192ee5a9"><code>90b29f8</code></a> Update CHANGELOG for 3.15.0</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/53a6190b9c793f0b1801cd8b08afd58d3436bad6"><code>53a6190</code></a> Drop support for Python 3.8</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/5aa9e9cd7e0d25403c8d9d478bc3480bb5ca2456"><code>5aa9e9c</code></a> Add <code>spy_return_iter</code> attribute to <code>spy</code> (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/524">#524</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/dc6df75a91aad4980af1a711e42a2ade19960f36"><code>dc6df75</code></a> Bump pypa/gh-action-pypi-publish in /.github/workflows (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/526">#526</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/b977d83d051390c5efd91b02884236ea5eba8ae4"><code>b977d83</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/525">#525</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/bd66c9cb8b1ffc59b4d9e42a1b413bafa3a16eac"><code>bd66c9c</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/523">#523</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/f9e47b6e1685169972488391d8c2ba1d10e0901d"><code>f9e47b6</code></a> Bump the github-actions group with 2 updates (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/521">#521</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/3aec7677f47f6c4b89dbdee9e4a32a8fe047943f"><code>3aec767</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/522">#522</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/e09e5be3fcaa54102006b7c01add91ac33ebf9ed"><code>e09e5be</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/520">#520</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/ba83a70ff9c15c0b8534e7f1a7c6ba5321aea046"><code>ba83a70</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/518">#518</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-mock/compare/v3.14.1...v3.15.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.