bug: nginx proxy_redirect no default setting

[xiangtianyu]

Current Behavior

I create a new route

{
  "uri": "/*",
  "name": "/",
  "priority": -1,
  "methods": [
    "GET",
    "POST",
    "PUT",
    "DELETE",
    "PATCH",
    "HEAD",
    "OPTIONS",
    "TRACE"
  ],
  "host": "xxx.test.com",
  "upstream_id": "00000000000000000001",
  "status": 1
} 

with upstream

{
  "nodes": [
    {
      "host": "test.inner.com",
      "port": 80,
      "weight": 1
    }
  ],
  "timeout": {
    "connect": 60,
    "send": 60,
    "read": 60
  },
  "type": "roundrobin",
  "hash_on": "vars",
  "scheme": "http",
  "pass_host": "node",
  "name": "test.inner.com",
  "keepalive_pool": {
    "idle_timeout": 320,
    "requests": 60,
    "size": 1000
  }
}

The xxx.test.com is normal domain and the test.inner.com is our Intranet domain, when we request the url it will redirect 301 by our app and the returned location host is test.inner.com, that caused failed. The old nginx gateway has a default set of proxy_redirect default, so the location host is xxx.test.com, but apisix not.

Expected Behavior

response header location host should be xxx.test.com

Error Logs

No response

Steps to Reproduce

create route and upsteam and will reproduce

Environment

• APISIX version (run apisix version): 3.9
• Operating system (run uname -a): centos
• OpenResty / Nginx version (run openresty -V or nginx -V):
• etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
• APISIX Dashboard version, if relevant:
• Plugin runner version, for issues related to plugin runners:
• LuaRocks version, for installation issues (run luarocks --version):

[Baoyuantop]

Can you use the response-rewrite plugin to accomplish this requirement? https://apisix.apache.org/docs/apisix/plugins/response-rewrite/

[xiangtianyu]

Can you use the response-rewrite plugin to accomplish this requirement? https://apisix.apache.org/docs/apisix/plugins/response-rewrite/

This plugin can rewrite the Location header, but i cannot get the real host in this plugin. And also the proxy_redirect default should do some host compare, it's also unable to do in the plugin

[Baoyuantop]

You can try the Customize Nginx configuration https://apisix.apache.org/docs/apisix/customize-nginx-configuration/

[xiangtianyu]

You can try the Customize Nginx configuration https://apisix.apache.org/docs/apisix/customize-nginx-configuration/

I've tried, and unfortunately the nginx default config of proxy_redirect is default. If i want to set this config as default by using "Customize Nginx configuration", it will always cause error： "proxy_redirect default" should be placed after the "proxy_pass" directive in /usr/local/apisix/conf/nginx.conf:283

[Baoyuantop]

but i cannot get the real host in this plugin.

Can you explain this in detail?

[xiangtianyu]

but i cannot get the real host in this plugin.

Can you explain this in detail?

If i request this url "http://xxx.test.com/test" and it redirect in the backend "http://test.inner.com/api/test". The "Location" of the 302 request will be like "http://test.inner.com/api/test", while it should be "http://xxx.test.com/api/test"

[Baoyuantop]

Will this configuration solve the problem?

plugins:
  response-rewrite:
    filters:
      - regex: "http[s]?://test\\.inner\\.com(/.*)"
        replace: "http://$host$1"
        scope: "global"
    vars:
      - ["status", "IN", [301, 302]]

[xiangtianyu]

Will this configuration solve the problem?

plugins:
  response-rewrite:
    filters:
      - regex: "http[s]?://test\\.inner\\.com(/.*)"
        replace: "http://$host$1"
        scope: "global"
    vars:
      - ["status", "IN", [301, 302]]

It might replace all in the response? Not just Location?

[Baoyuantop]

plugins:
  response-rewrite:
    headers:
      set:
        Location: "$regex_replace($http_location, 'http[s]?://test\\.inner\\.com(/.*)', 'http://$host$1')"
    vars:
      - ["status", "IN", [301, 302]]
      - ["http_location", "exists", true]

[xiangtianyu]

plugins:
  response-rewrite:
    headers:
      set:
        Location: "$regex_replace($http_location, 'http[s]?://test\\.inner\\.com(/.*)', 'http://$host$1')"
    vars:
      - ["status", "IN", [301, 302]]
      - ["http_location", "exists", true]

It can not perfectly replace "proxy_redirect default", because there're some special cases, such as "proxy pass http://test.inner.com/api", if the redirect url is "http://test.inner.com/xxx" it will not replace host to "xxx.test.com", because "/xxx" and "/api" failed to match. The "response-rewrite" plugin cannot perfectly equal to "proxy_redirect default"