Fix LoadBalancer service field and improve template maintainability #2079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR improves the AWX service template (roles/installer/templates/networking/service.yaml.j2) by fixing critical bugs, simplifying logic, and enhancing maintainability.
Key Changes:
The changes maintain full backward compatibility while fixing a deployment-breaking bug for LoadBalancer services and significantly improving code maintainability.
ISSUE TYPE
ADDITIONAL INFORMATION
Bug Details:
The loadbalancerip field was preventing LoadBalancer services from working correctly. Kubernetes requires the field to be capitalized as loadBalancerIP.
Validation Added:
Code Improvements:
Testing:
The changes preserve existing functionality while adding safety checks.
All service types (ClusterIP, NodePort, LoadBalancer) continue to work as expected.
Before: Typon LoadBalancer configuration
loadbalancerip: '{{ loadbalancer_ip }}'
After: Correct Kubernetes API field
loadBalancerIP: '{{ loadbalancer_ip }}'