Add HOME to safe env vars #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some build systems, such as nix, will modify HOME env var to provide a writable home dir. If the modify HOME env var is cleared, and the original home dir of the build user is not writable, some tests will fail.
|
I'd expect this to need a test case. |
ssbarnea
approved these changes
Nov 10, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build systems, such as nix, will modify HOME env var to provide a
writable home dir.
If the modify HOME env var is cleared, and the original home dir of the
build user is not writable, some tests will fail.
Failed build log of ansible-lint on nix aarch64-darwin https://hydra.nixos.org/build/157038092/nixlog/1