Parameter insecure_registry added to helm_template #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s |
yurnov
force-pushed
the
20241207-add-insecure-skip-tls-verify-to-helm-template
branch
from
2a53352 to
f9126a0
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 37s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 52s |
…nsecure-skip-tls-verify
…tual location" This reverts commit 90afebf.
yurnov
force-pushed
the
20241207-add-insecure-skip-tls-verify-to-helm-template
branch
from
33930aa to
195d089
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 48s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 36s |
abikouo
approved these changes
Dec 17, 2024
abikouo
added
the
test-all-the-targets
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #835 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (cherry picked from commit 6609abd)
abikouo
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (cherry picked from commit 6609abd) Co-authored-by: Yuriy Novostavskiy <[email protected]>
This was referenced Jan 20, 2025
Closed
Merged
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
SUMMARY This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes. ISSUE TYPE New release pull request Changelog Minor Changes Bump version of ansible-lint to minimum 24.7.0 (#765). Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (#805). connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (#741). k8s_drain - Improve error message for pod disruption budget when draining a node (#797). Bugfixes helm - Helm version checks did not support RC versions. They now accept any version tags. (#745). helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (#796). k8s_drain - Fix k8s_drain does not wait for single pod (#769). k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set (#792). kubeconfig option should not appear in module invocation log (#782). kustomize - kustomize plugin fails with deprecation warnings (#639). waiter - Fix waiting for daemonset when desired number of pods is 0. (#756). New Modules helm_registry_auth - Helm registry authentication module ADDITIONAL INFORMATION Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0 Reviewed-by: Mike Graves <[email protected]>
yurnov
added a commit
to yurnov/kubernetes.core
that referenced
this pull request
Jan 20, 2025
SUMMARY This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes. ISSUE TYPE New release pull request Changelog Minor Changes Bump version of ansible-lint to minimum 24.7.0 (ansible-collections#765). Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (ansible-collections#805). connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (ansible-collections#741). k8s_drain - Improve error message for pod disruption budget when draining a node (ansible-collections#797). Bugfixes helm - Helm version checks did not support RC versions. They now accept any version tags. (ansible-collections#745). helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (ansible-collections#796). k8s_drain - Fix k8s_drain does not wait for single pod (ansible-collections#769). k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set (ansible-collections#792). kubeconfig option should not appear in module invocation log (ansible-collections#782). kustomize - kustomize plugin fails with deprecation warnings (ansible-collections#639). waiter - Fix waiting for daemonset when desired number of pods is 0. (ansible-collections#756). New Modules helm_registry_auth - Helm registry authentication module ADDITIONAL INFORMATION Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0 Reviewed-by: Mike Graves <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2025
SUMMARY Added the option insecure_skip_tls_verify to the following helm modules: helm_repository helm Unified the option with alias in helm_pull For helm, added the option to the helm diff call, as it got fixed upstream. Upstream Issue: databus23/helm-diff#503 Fixed with: helm/helm#12856 Fixes #694 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm kubernetes.core.helm_repository kubernetes.core.helm_pull ADDITIONAL INFORMATION Basically the option was added in the parameters set in the ansible job, in the docs and then injected in the helm and helm diff binary calls if set. Defaults to False. Example --- - name: Test helm modules tasks: - name: Test helm repository insecure kubernetes.core.helm_repository: name: insecure repo_url: "<helm-repo-with-self-signed-tls>" state: present insecure_skip_tls_verify: true - name: Test helm pull insecure kubernetes.core.helm_pull: chart_ref: "oci://<helm-repo-with-self-signed-tls>/ptroject" destination: /tmp insecure_skip_tls_verify: true - name: Test helm insecure kubernetes.core.helm: name: insecure chart_ref: "oci://<helm-repo-with-self-signed-tls>/project" namespace: helm-insecure-test state: present insecure_skip_tls_verify: true Note Might need an alias for telm_template, as the option is called insecure_registry, in the manual and docs of helm it would be --insecure-skip-tls-verify as well though. Not included, as it was recently merged with #805 Reviewed-by: Yuriy Novostavskiy Reviewed-by: Noah Lehmann Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <[email protected]> Reviewed-by: Mike Graves <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
May 2, 2025
SUMMARY Added the option insecure_skip_tls_verify to the following helm modules: helm_repository helm Unified the option with alias in helm_pull For helm, added the option to the helm diff call, as it got fixed upstream. Upstream Issue: databus23/helm-diff#503 Fixed with: helm/helm#12856 Fixes #694 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm kubernetes.core.helm_repository kubernetes.core.helm_pull ADDITIONAL INFORMATION Basically the option was added in the parameters set in the ansible job, in the docs and then injected in the helm and helm diff binary calls if set. Defaults to False. Example --- - name: Test helm modules tasks: - name: Test helm repository insecure kubernetes.core.helm_repository: name: insecure repo_url: "<helm-repo-with-self-signed-tls>" state: present insecure_skip_tls_verify: true - name: Test helm pull insecure kubernetes.core.helm_pull: chart_ref: "oci://<helm-repo-with-self-signed-tls>/ptroject" destination: /tmp insecure_skip_tls_verify: true - name: Test helm insecure kubernetes.core.helm: name: insecure chart_ref: "oci://<helm-repo-with-self-signed-tls>/project" namespace: helm-insecure-test state: present insecure_skip_tls_verify: true Note Might need an alias for telm_template, as the option is called insecure_registry, in the manual and docs of helm it would be --insecure-skip-tls-verify as well though. Not included, as it was recently merged with #805 Reviewed-by: Yuriy Novostavskiy Reviewed-by: Noah Lehmann Reviewed-by: Bikouo Aubin Reviewed-by: Bianca Henderson <[email protected]> Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 914a16e)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 6, 2025
This is a backport of PR #901 as merged into main (914a16e). SUMMARY Added the option insecure_skip_tls_verify to the following helm modules: helm_repository helm Unified the option with alias in helm_pull For helm, added the option to the helm diff call, as it got fixed upstream. Upstream Issue: databus23/helm-diff#503 Fixed with: helm/helm#12856 Fixes #694 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm kubernetes.core.helm_repository kubernetes.core.helm_pull ADDITIONAL INFORMATION Basically the option was added in the parameters set in the ansible job, in the docs and then injected in the helm and helm diff binary calls if set. Defaults to False. Example --- - name: Test helm modules tasks: - name: Test helm repository insecure kubernetes.core.helm_repository: name: insecure repo_url: "<helm-repo-with-self-signed-tls>" state: present insecure_skip_tls_verify: true - name: Test helm pull insecure kubernetes.core.helm_pull: chart_ref: "oci://<helm-repo-with-self-signed-tls>/ptroject" destination: /tmp insecure_skip_tls_verify: true - name: Test helm insecure kubernetes.core.helm: name: insecure chart_ref: "oci://<helm-repo-with-self-signed-tls>/project" namespace: helm-insecure-test state: present insecure_skip_tls_verify: true Note Might need an alias for telm_template, as the option is called insecure_registry, in the manual and docs of helm it would be --insecure-skip-tls-verify as well though. Not included, as it was recently merged with #805 Reviewed-by: Bianca Henderson <[email protected]> Reviewed-by: Mike Graves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter
insecure_registryadded tohelm_templateas equivalent ofinsecure-skip-tls-verifySUMMARY
This PR is created to address #801
ISSUE TYPE
COMPONENT NAME
helm_template