fix(CMSIS): Call PinInit from SystemInit in RISC-V startup #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ARM core startup already calls PinInit() to configure the pinmux when using CFS. The RISC-V core needs to do the same. We create a weak PinInit() function and call it before BoardInit(). Also, correct spelling of "over-ride" to "override". Signed-off-by: Michael Perkins <[email protected]>
github-actions
bot
added
MAX32520
github-actions
bot
added
MAX78002
sihyung-maxim
approved these changes
Sep 5, 2025
|
Hi @sihyung-maxim - do you know how to get the test to pass? I don't think the failure is due to these changes, and I can't merge with it failing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ARM core startup already calls PinInit() to configure the pinmux when using CFS. The RISC-V core needs to do the same.
We create a weak PinInit() function and call it before BoardInit(). Also, correct spelling of "over-ride" to "override".
Checklist Before Requesting Review