Skip to content

scripts: backstage: Make library key shorted to fit 63 char #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

scripts: backstage: Make library key shorted to fit 63 char #1906

wants to merge 1 commit into from

Conversation

gastmaier
Copy link
Contributor

PR Description

The length limit for the component is 63 characters, so

hdl-library-i3c_controller-i3c_controller_host_interface-2023_r2

would cause errors.
Drop the path lib, just keep the right-most section instead

hdl-library-i3c_controller_host_interface-2023_r2

To save some characters.

I need to remember the implications to the already existing content in the backstage branch.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@gastmaier
scripts: backstage: Make library key shorted to fit 63 char
94b91ec 
The length limit for the component is 63 characters, so

  hdl-library-i3c_controller-i3c_controller_host_interface-2023_r2

would cause errors.
Drop the path lib, just keep the right-most section instead

  hdl-library-i3c_controller_host_interface-2023_r2

To save some characters.

Signed-off-by: Jorge Marques <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina Awaiting requested review from acostina acostina will be requested when the pull request is marked ready for review acostina is a code owner

@AndreiGrozav AndreiGrozav Awaiting requested review from AndreiGrozav AndreiGrozav will be requested when the pull request is marked ready for review AndreiGrozav is a code owner

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021 PopPaul2021 will be requested when the pull request is marked ready for review PopPaul2021 is a code owner

@sarpadi sarpadi Awaiting requested review from sarpadi sarpadi will be requested when the pull request is marked ready for review sarpadi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gastmaier